David
f74773132a
Step 2 replaced uuid by crypto.randomUUID() at three call sites (AlexaStatusMessage, AlexaErrorResponse, Device.sendSceneResponse) and only the first was asserted, in the ES module test. With the messageId dropped or set to a constant in the other two, the suite still passed 22/22, and no test read an ErrorResponse at all. New: an ErrorResponse compared whole against the documented shape (header, endpoint, payload, no context), and one test that sends two directives each to a light, an unreachable light and a scene and requires six different version 4 UUIDs. The Response, StateReport, scene and change report tests check the messageId too; the pattern lives in the harness. Checked in a scratch copy: a missing or constant messageId at each of the three sites now fails the suite (the missing one in AlexaStatusMessage does not compile). No change to src/ or dist/. npm test: 24 pass in 5.5 s. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
30 lines
1.6 KiB
JavaScript
30 lines
1.6 KiB
JavaScript
"use strict";
|
|
// Alexa.ChangeReport: published on <root>/changeReport, where Alex2MQTT adds the user's token and posts it to the
|
|
// Alexa event gateway.
|
|
const { test } = require("node:test");
|
|
const assert = require("node:assert/strict");
|
|
const { Alex2MQTT, AlexaInterfaceType, DisplayCategory, PowerController } = require("alex2node");
|
|
const { setup, until, UUID_V4 } = require("./helpers/harness.js");
|
|
|
|
test("a change report carries the changed properties in payload.change and the rest in context", async () => {
|
|
const { alexa, bridge } = await setup(Alex2MQTT, "root");
|
|
const lamp = bridge.registerDevice("Dining Room Light", "5020AA", DisplayCategory.LIGHT);
|
|
lamp.addCapability(AlexaInterfaceType.POWER_CONTROLLER, { proactivelyReported: true });
|
|
lamp.addCapability(AlexaInterfaceType.BRIGHTNESS_CONTROLLER);
|
|
|
|
const topic = await lamp.getChangeReport("PHYSICAL_INTERACTION")
|
|
.addPowerControllerProp(PowerController.OFF)
|
|
.unchanged()
|
|
.addBrightnessControllerProp(0)
|
|
.send();
|
|
assert.equal(topic, "root/changeReport");
|
|
|
|
await until(() => alexa.on("root/changeReport").length === 1, 3000, "change report");
|
|
const [report] = alexa.on("root/changeReport");
|
|
assert.equal(report.event.header.name, "ChangeReport");
|
|
assert.match(report.event.header.messageId, UUID_V4);
|
|
assert.equal(report.event.endpoint.endpointId, "5020AA");
|
|
assert.equal(report.event.payload.change.cause.type, "PHYSICAL_INTERACTION");
|
|
assert.deepEqual(report.event.payload.change.properties.map((p) => [p.name, p.value]), [["powerState", "OFF"]]);
|
|
assert.deepEqual(report.context.properties.map((p) => [p.name, p.value]), [["brightness", 0]]);
|
|
});
|