apps/Alex2Node
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

test: read an ErrorResponse off the broker; every answer has its own messageId

Browse source 
Step 2 replaced uuid by crypto.randomUUID() at three call sites (AlexaStatusMessage, AlexaErrorResponse,
Device.sendSceneResponse) and only the first was asserted, in the ES module test. With the messageId dropped or set
to a constant in the other two, the suite still passed 22/22, and no test read an ErrorResponse at all.

New: an ErrorResponse compared whole against the documented shape (header, endpoint, payload, no context), and one
test that sends two directives each to a light, an unreachable light and a scene and requires six different
version 4 UUIDs. The Response, StateReport, scene and change report tests check the messageId too; the pattern
lives in the harness.

Checked in a scratch copy: a missing or constant messageId at each of the three sites now fails the suite (the
missing one in AlexaStatusMessage does not compile). No change to src/ or dist/. npm test: 24 pass in 5.5 s.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
David 2026-09-28 14:26:44 +00:00
parent 1d88c7811a
commit f74773132a
4 changed files with 78 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

3
test/change-report.test.js
View file

@ -4,7 +4,7 @@
const { test } = require("node:test");
const assert = require("node:assert/strict");
const { Alex2MQTT, AlexaInterfaceType, DisplayCategory, PowerController } = require("alex2node");
const { setup, until } = require("./helpers/harness.js");
const { setup, until, UUID_V4 } = require("./helpers/harness.js");
test("a change report carries the changed properties in payload.change and the rest in context", async () => {
const { alexa, bridge } = await setup(Alex2MQTT, "root");
@ -22,6 +22,7 @@ test("a change report carries the changed properties in payload.change and the r
await until(() => alexa.on("root/changeReport").length === 1, 3000, "change report");
const [report] = alexa.on("root/changeReport");
assert.equal(report.event.header.name, "ChangeReport");
assert.match(report.event.header.messageId, UUID_V4);
assert.equal(report.event.endpoint.endpointId, "5020AA");
assert.equal(report.event.payload.change.cause.type, "PHYSICAL_INTERACTION");
assert.deepEqual(report.event.payload.change.properties.map((p) => [p.name, p.value]), [["powerState", "OFF"]]);